-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major: upgrade deps, node 20, actions #27
Conversation
Looks good. Thanks! I think we can release this with only a minor version bump though. The public behaviour of the action didn't change. Or did I miss something? |
No, you are right. No behaviour changes. |
Okay. Released as Thanks for the PR! 🥳 |
Thanks for merging, but you did not create a release. Any reason? |
I tagged |
Ah, I forgot about the github release thingy. Made the new releases now too. |
From the docs, I agree that node20 should be fine. Lets see what we find out at #28. In the mean time the downgrade is the safe option. But if it's an outdated custom runner, then I think we can just add a note to the README to use |
Alright, upgraded and released again :p Thanks again for doing the maintenance! |
Was there a reason that the |
Yes, the javascript code is required for workflows using the action. They don't run the typescript compiler first. (It was already included before too.) |
No description provided.